[Webkit-unassigned] [Bug 46405] Add idl and mock classes for FileSystemSync for FileSystem API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46405





--- Comment #5 from Kinuko Yasuda <kinuko at chromium.org>  2010-09-30 12:55:29 PST ---
(In reply to comment #2)
> (From update of attachment 68597 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68597&action=review
> 
> > WebCore/bindings/js/JSDirectoryEntrySyncCustom.cpp:59
> > +        JSValue jsCreate = object->get(exec, Identifier(exec, "create"));
> 
> This call re-enters JavaScript and can do arbitrary things.  How do we know that |object| hasn't been deallocated?  What about |imp|?

Per webkit-dev's feedback, they must be referenced by the current executing code and shouldn't be deallocated while they are being executed.

> > WebCore/bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:75
> > +    } else {
> > +       EXCEPTION_BLOCK(Flags*, tmp_flags, V8Flags::HasInstance(args[1]) ? V8Flags::toNative(v8::Handle<v8::Object>::Cast(args[1])) : 0);
> > +       flags = tmp_flags;
> > +    }
> 
> Bad indent.

Fixed.

(In reply to comment #3)
> It seems that at this point some test should be possible. If nothing else, some tests for invalid values and verifying that appropriate erros are given.

Added basic tests that test requestFileSystem and requestFileSystemSync in workers (and in non-workers too for the former).

The patch size has increased some... I hope it'd be ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.