[Webkit-unassigned] [Bug 46335] Add EditingStyle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46335





--- Comment #6 from Eric Seidel <eric at webkit.org>  2010-09-30 12:45:20 PST ---
(From update of attachment 69363)
View in context: https://bugs.webkit.org/attachment.cgi?id=69363&action=review

> WebCore/editing/CompositeEditCommand.cpp:935
> +        styleInEmptyParagraph = editingStyleIncludingTypingStyle(startOfParagraphToMove.deepEquivalent());

Is there an editing style which does not include typing style?

> WebCore/editing/CompositeEditCommand.cpp:1052
> +        applyStyle(style->style());

Does applyStyle ASSERT ! empty?  Or should this check just go into applyStyle?

> WebCore/editing/DeleteSelectionCommand.cpp:297
> +    m_typingStyle = EditingStyle::create(positionBeforeTabSpan(m_selectionToDelete.start()));

I take it this is an editing style which does not include the typing style?

> WebCore/editing/EditingStyle.cpp:51
> +: m_shouldUseFixedDefaultFontSize(false)

indent.

> WebCore/editing/EditingStyle.cpp:56
> +: m_shouldUseFixedDefaultFontSize(false)

again.

> WebCore/editing/EditingStyle.cpp:131
> +    if (!m_mutableStyle)
> +        return;
> +
> +    m_mutableStyle->removeBlockProperties();

I would have probably just reversed this if since it's one line.

> WebCore/editing/EditingStyle.cpp:146
> +        CSSPrimitiveValue* primitiveValue = static_cast<CSSPrimitiveValue*>(backgroundColor.get());
> +        Color color = Color(primitiveValue->getRGBA32Value());

This is the way we build colors from CSSPrimativeValues?  I would have expected there to be a function or constructor which did this.

> WebCore/editing/EditingStyle.h:78
> +    void init(Node*);

What is the purpose of a separate init() call?  Generally we don't have separate init() in webkit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.