[Webkit-unassigned] [Bug 44329] SH4 JIT SUPPORT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44329





--- Comment #18 from Patrick R. Gansterer <paroga at paroga.com>  2010-09-30 11:31:31 PST ---
(From update of attachment 69349)
View in context: https://bugs.webkit.org/attachment.cgi?id=69349&action=review

> JavaScriptCore/ChangeLog:10
> +        Add assembler instructions for SH4 platform
> +
> +        * GNUmakefile.am:
> +        * assembler/MacroAssembler.h:
> +        * jit/ExecutableAllocator.h:
> +        (JSC::ExecutableAllocator::cacheFlush):

You do not mention the implementation of chacheFlush for SH4 in the ChangeLog. Maybe you can create a own patch only for the changes in ExecutableAllocator.h.

> JavaScriptCore/jit/ExecutableAllocator.h:310
> +static const unsigned defaultLinuxPageSize = 4096;

IMHO this should be intendet 4 spaces, because it's C code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.