[Webkit-unassigned] [Bug 38381] [Windows] Implement <input type=number> UI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38381





--- Comment #4 from Kent Tamura <tkent at chromium.org>  2010-09-30 00:20:19 PST ---
(From update of attachment 61177)
View in context: https://bugs.webkit.org/attachment.cgi?id=61177&action=review

>> WebCore/rendering/RenderThemeWin.cpp:98
>> +// Spin button staes
> 
> states spelled incorrectly

Fixed.

>> WebCore/rendering/RenderThemeWin.cpp:500
>> +}
> 
> extra new line that's not needed

Fixed.

>> WebCore/rendering/RenderThemeWin.cpp:516
>> +            result.m_state = determineClassicState(o, false);
> 
> instead of using a bool here, a simple ENUM would be helpful so that when looking at lines like this, it's clear that you're passing in a down button

Fixed.  I introduced ControlSubPart enum, which is the same as RenderThemeChromiumWin.

>> WebCore/rendering/RenderThemeWin.cpp:680
>> +        width = 17; // Vista's default.
> 
> can you retrieve this from some system setting if it's a default?

I don't think we can.

>> WebCore/rendering/RenderThemeWin.cpp:688
>> +        return false;
> 
> why less than 2 and not 1 or 3?

I added a comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.