[Webkit-unassigned] [Bug 45750] Move backing-store contents on slow scrolls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45750





--- Comment #5 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-09-29 19:52:06 PST ---
(From update of attachment 67551)
View in context: https://bugs.webkit.org/attachment.cgi?id=67551&action=review

> WebCore/ChangeLog:9
> +        With this information is possible to scroll the backing-store contents
> +        without redrawing the whole scrolled area.

Without this change we can acomplish this for Qt. You are also introducing behaviour changes elsewhere and there are no tests, thus r-.

> WebCore/page/ChromeClient.h:138
> +        virtual void invalidateContentsForSlowScroll(const IntSize&, const IntRect&, bool) = 0;

it is not obvious what the size here is for so I would write out the variable name... is it for a delta? The original method is not much better though, I wonder what the bool is for!

> WebCore/platform/ScrollView.cpp:544
> -       hostWindow()->invalidateContentsForSlowScroll(updateRect, false);
> +       hostWindow()->invalidateContentsForSlowScroll(-scrollDelta, updateRect, false);

There seems to be behaviour changes here, where are the layout tests?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.