[Webkit-unassigned] [Bug 45773] Add isMainFrame flag to scroll functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45773


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67592|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-09-29 19:48:05 PST ---
(From update of attachment 67592)
View in context: https://bugs.webkit.org/attachment.cgi?id=67592&action=review

I don't really understand why this is needed, and as such I cannot say if this is the best way of accomplishing what you are trying to do.

r- for this reason.

> WebCore/ChangeLog:8
> +        This information is needed by the new EFL tiled backing store.

This would probably need more explanation. Why is that needed for the EFL tiled backing store. - you should explain that instead

> WebCore/loader/EmptyClients.h:151
> +    virtual void invalidateContentsForSlowScroll(const IntSize&, const IntRect&, bool, bool) {};
> +    virtual void scroll(const IntSize&, const IntRect&, const IntRect&, bool) { }

We are trying to more away from bool arguments. Consider using enums instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.