[Webkit-unassigned] [Bug 46850] Add GetGraphicsResetStatusARB entry point from ARB_robustness extension to GraphicsContext3D

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46850





--- Comment #5 from Chris Marrin <cmarrin at apple.com>  2010-09-29 18:11:30 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 69279 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=69279&action=review
> > 
> > > WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:1456
> > > +
> > 
> > I don't understand the point of this patch. It doesn't hook anything up. It simply adds placeholders. You should do at least one implementation to show that it actually works, along with a test case with a bad shader that will crash if ARB_robustness is not there.
> > 
> > I understand if this is just a stepping stone to that goal. But this bug is for "hooking up" the extension, which this patch doesn't do.
> 
> Several steps are needed toward the goal of handling "context lost" events in WebGL and other functionality such as CSS 3D support. Adding the needed entry points to GraphicsContext3D allows some of this work to occur in parallel.
> 
> I have updated the synopsis of this bug to reflect the intent.

Ok, that's better. Maybe you should create an umbrella bug so we can keep track of all the work?

I will amend my review

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.