[Webkit-unassigned] [Bug 46850] Wire GetGraphicsResetStatusARB from ARB_robustness extension in GraphicsContext3D

Wed Sep 29 17:28:53 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=46850

Chris Marrin <cmarrin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69279|review?                     |review-
               Flag|                            |

--- Comment #2 from Chris Marrin <cmarrin at apple.com>  2010-09-29 17:28:53 PST ---
(From update of attachment 69279)
View in context: https://bugs.webkit.org/attachment.cgi?id=69279&action=review

> WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:1456
> +

I don't understand the point of this patch. It doesn't hook anything up. It simply adds placeholders. You should do at least one implementation to show that it actually works, along with a test case with a bad shader that will crash if ARB_robustness is not there.

I understand if this is just a stepping stone to that goal. But this bug is for "hooking up" the extension, which this patch doesn't do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.