[Webkit-unassigned] [Bug 46839] Autocorrection shouldn't prompt the same correction after user has edited previous correction.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46839


jpu at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69260|                            |review?, commit-queue?
               Flag|                            |




--- Comment #1 from jpu at apple.com  2010-09-29 15:26:00 PST ---
Created an attachment (id=69260)
 --> (https://bugs.webkit.org/attachment.cgi?id=69260)
Proposed patch (v1)

Prior to bug 45709. We use "Replacement" marker to indicate the word that has been autocorrected and need to be marked with underline. Whenever user edits an autocorrected word, in order to remove the underline, we remove the "Replacement" marker. However, doing this also prevents us from keeping track of on which word we have already applied autocorrection. So if the user corrects an autocorrection, we would keep prompting the same autocorrection suggestion.

In bug 45709, we introduced a new marker "CorrectionIndicator" to indicate whether we should draw underline. So now we can remove underline by removing "CorrectionIndicator" marker. This allows us to keep "Replacement" marker around, so that we won't suggest autocorrection on word that already bears "Replacement" marker.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.