[Webkit-unassigned] [Bug 46563] Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46563


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69215|review?                     |review+
               Flag|                            |




--- Comment #8 from David Levin <levin at chromium.org>  2010-09-29 14:25:57 PST ---
(From update of attachment 69215)
View in context: https://bugs.webkit.org/attachment.cgi?id=69215&action=review

PLease consider fixing the following before landing this change.

> LayoutTests/fast/filesystem/resources/fs-test-util.js:18
> +// FIXME: replace this with the API's one once the backend fully supports removeRecursively.

I had a hard time understanding this comment. Is this the same idea?

// FIXME: replace this code with the equivalent File API method once the it fully supports removeRecursively.

> WebCore/fileapi/DirectoryReader.h:45
> +class EntriesCallbacks;

Please sort.

> WebCore/fileapi/FileSystemCallbacks.cpp:167
> +        m_directoryReader->setHasMore(hasMore);

Why is this call only done if m_successCallback is set? It seems like it should always be done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.