[Webkit-unassigned] [Bug 46834] Limit number of AudioNode deletions per render quantum in AudioContext

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 29 13:07:07 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=46834


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69242|review?                     |review-
               Flag|                            |




--- Comment #3 from Kenneth Russell <kbr at google.com>  2010-09-29 13:07:06 PST ---
(From update of attachment 69242)
View in context: https://bugs.webkit.org/attachment.cgi?id=69242&action=review

There are several changes in this patch unrelated to this bug that need to be removed.

> WebCore/webaudio/AudioContext.cpp:110
> +    m_hrtfDatabaseLoader = HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary(sampleRate());

This is an unrelated change.

> WebCore/webaudio/AudioContext.cpp:351
> +        m_graphOwnerThread = thisThread;

This also looks like an unrelated change.

> WebCore/webaudio/AudioContext.cpp:438
> +    ASSERT(isAudioThread() && isGraphOwner());

Is this new assertion related to this change?

> WebCore/webaudio/AudioContext.h:248
> +    RefPtr<HRTFDatabaseLoader> m_hrtfDatabaseLoader;

Unrelated changes shouldn't be in this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list