[Webkit-unassigned] [Bug 46259] [Qt] QNetworkReplyHandler forces buffered output for FormData with files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46259


Andreas Kling <andreas.kling at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68360|review?                     |review-
               Flag|                            |




--- Comment #2 from Andreas Kling <andreas.kling at nokia.com>  2010-09-29 01:11:54 PST ---
(From update of attachment 68360)
View in context: https://bugs.webkit.org/attachment.cgi?id=68360&action=review

r- for compilation-breaking typo and missing ChangeLog entry.
Please see http://trac.webkit.org/wiki/QtWebKitContrib for information on how to make patches for WebKit, specifically the "Submitting a patch" section.

> QNetworkReplyHandler.h.new:100
> +    qint64 getFormDataSize() { return m_totalSize; }

This method should be const.

> QNetworkReplyHandler.cpp.new:70
> +    m_totalSize=computeSize();

Coding style, should be "m_totalSize = computeSize();"

> QNetworkReplyHandler.cpp.new:81
> +    for (int i=0; i<m_formElements.size(); i++)

Coding style, should be "for (int i = 0; i < m_formElements.size(); ++i)"

> QNetworkReplyHandler.cpp.new:84
> +        if (element.m_type == FormDataElement::data) {

Coding style, shouldn't have {

> QNetworkReplyHandler.cpp.new:85
> +            m_dataSize+=element.m_data.size();

Coding style, should be "m_dataSize += element.m_data.size();"

> QNetworkReplyHandler.cpp.new:88
> +            m_fileSize+=fi.size();

Coding style, should be "m_fileSize += fi.size();"

> QNetworkReplyHandler.cpp.new:94
> +    return (m_dataSize + m_fileSize);

Unnecessary parentheses.

> QNetworkReplyHandler.cpp.new:482
> +            //We may be uploading files so prevent QNR from buffering data

Coding style, please leave a space after //

> QNetworkReplyHandler.cpp.new:483
> +            m_request.setHeader(QNetworkRequest::ContentLengthHeader, posdDevice->getFormDataSize());

Typo, "posdDevice" should be "postDevice"

> QNetworkReplyHandler.cpp.new:494
> +            //We may be uploading files so prevent QNR from buffering data

Coding style, please leave a space after //

> QNetworkReplyHandler.cpp.new:495
> +            m_request.setHeader(QNetworkRequest::ContentLengthHeader, posdDevice->getFormDataSize());

Typo, "posdDevice" should be "postDevice"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.