[Webkit-unassigned] [Bug 46771] GraphicsContext3D.cpp files are confusing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 28 18:35:40 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=46771


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69148|review?                     |review-
               Flag|                            |




--- Comment #2 from Kenneth Russell <kbr at google.com>  2010-09-28 18:35:41 PST ---
(From update of attachment 69148)
You need to take into consideration that platform/graphics/GraphicsContext3D.cpp is currently compiled in to all platforms. You will minimally need to also modify WebCore/WebCore.xcodeproj/project.pbxproj . I don't know whether you need to strictly make this modification in Xcode or whether you can do it in a text editor. You should also do a recursive grep on all flat files in the WebKit workspace to see where else this file name is referenced. Since the bots apparently can't build on Mac unless you're a WebKit committer I strongly suggest testing your build modifications on Mac OS X -- or your reviewer will need to do so for safety.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list