[Webkit-unassigned] [Bug 43071] ASSERTION FAILURE in AppendNodeCommand::AppendNodeCommand when indenting HTML

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 28 17:38:04 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=43071





--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org>  2010-09-28 17:38:04 PST ---
Replacing

RefPtr<Node> outerBlock = (start.node() == nodeToSplitTo) ? start.node() : splitTreeToNode(start.node(), nodeToSplitTo);

by

+    RefPtr<Node> outerBlock = start.node();
+    bool different = false;
+    for (Node* n = start.node(); n && n != nodeToSplitTo; n = n->parentNode())
+        if (visiblePositionBeforeNode(n) != visiblePositionBeforeNode(start.node()))
+            different = true;
+    if (start.node() != nodeToSplitTo && different)
+        outerBlock = splitTreeToNode(start.node(), nodeToSplitTo);

seems to work.  The idea is to avoid splitting the tree when nodes between start.node() and nodeToSplitTo belong to the current paragraph.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list