[Webkit-unassigned] [Bug 46290] Add AudioChannelSplitter files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46290





--- Comment #5 from Chris Rogers <crogers at google.com>  2010-09-28 16:04:51 PST ---
(From update of attachment 68414)
View in context: https://bugs.webkit.org/attachment.cgi?id=68414&action=review

>> WebCore/webaudio/AudioChannelSplitter.cpp:40
>> +// This is considering that 5.1 (6 channels is the largest we'll ever deal with).
> 
> This isn't a complete sentence.

FIXED

>> WebCore/webaudio/AudioChannelSplitter.cpp:58
>> +void AudioChannelSplitter::process(size_t /*framesToProcess*/)
> 
> In the .cpp, since the argument is completely unused, just leave the name off rather than commenting it out.

I've added the following just for a little extra safety:
    ASSERT_UNUSED(framesToProcess, framesToProcess == source->length());

>> WebCore/webaudio/AudioChannelSplitter.cpp:85
>> +void AudioChannelSplitter::initialize()
> 
> It looks like every AudioNode subclass has this exact same initialize() and uninitialize() method. They should be refactored into the base class. At that point m_isInitialized could be private in AudioNode.

FIXED: I've changed AudioNode as you suggest (which I'll post as a separate patch)

>> WebCore/webaudio/AudioChannelSplitter.h:47
>> +    virtual void process(size_t /*framesToProcess*/);
> 
> I think the argument name should be uncommented.

FIXED

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.