[Webkit-unassigned] [Bug 46286] Add AudioGainNode files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46286





--- Comment #6 from Chris Rogers <crogers at google.com>  2010-09-28 15:52:18 PST ---
(From update of attachment 68731)
View in context: https://bugs.webkit.org/attachment.cgi?id=68731&action=review

>> WebCore/webaudio/AudioGainNode.h:52
>> +    virtual void process(size_t /*framesToProcess*/);
> 
> I'm not sure the commented-out argument name is WebKit style. Since the name is significant it's probably worth just using it.

FIXED

>> WebCore/webaudio/AudioGainNode.h:62
>> +    void setGain(PassRefPtr<AudioGain> gain) { m_gain = gain; }
> 
> Since the gain attribute in the IDL is readonly, and m_gain is initialized in the constructor, does setGain need to be exposed at all?

FIXED

>> WebCore/webaudio/AudioGainNode.idl:34
>> +        readonly attribute AudioGain gain;
> 
> The Web Audio API doesn't say this attribute is readonly.

I'ved added a FIXME here to keep it readonly for now, until proper thread safety can be added.  Although there are applications for writing this attribute, they're more advanced use cases.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.