[Webkit-unassigned] [Bug 46493] [chromium] Add mipmap support for ImageLayerChromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46493


Vangelis Kokkevis <vangelis at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69101|review?                     |review-
               Flag|                            |




--- Comment #12 from Vangelis Kokkevis <vangelis at chromium.org>  2010-09-28 14:52:18 PST ---
(From update of attachment 69101)
View in context: https://bugs.webkit.org/attachment.cgi?id=69101&action=review

> WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:281
> +            GLC(context, context->generateMipmap(GraphicsContext3D::TEXTURE_2D));

You'll need to also call generateMipmap in the "else" clause as well, if the conditions are met. I suggest doing something like:

bool doMipmap =  generateMipmap && (layerRenderer()->contentLayerSharedValues()->npotSupported() || (isPowerOfTwo(updateRect.width()) && isPowerOfTwo(updateRect.height())))

outside the if statement and the in the "if" part do:

if (doMipmap)
  set filter modes


and outside the if statement
if (doMipmap)
  generateMipmap

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.