[Webkit-unassigned] [Bug 46679] Delete and forward delete shouldn't start autocorrection panel timer.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 28 14:36:33 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=46679
--- Comment #16 from jpu at apple.com 2010-09-28 14:36:33 PST ---
(In reply to comment #14)
> (From update of attachment 69099 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69099&action=review
>
> > WebCore/editing/TypingCommand.cpp:321
> > +#if PLATFORM(MAC) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
> > void TypingCommand::typingAddedToOpenCommand(ETypingCommand commandTypeForAddedTyping)
> > +#else
> > +void TypingCommand::typingAddedToOpenCommand(ETypingCommand)
> > +#endif
>
> The complaint was about markMisspellingsAfterTyping() having an unused (in some configurations) parameter, not about this method, so I’m not sure why you’re changing this one. I think it will break all builds.
>
Sorry, totally messed up this one. Let me generate another patch, and test building it on both platforms
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list