[Webkit-unassigned] [Bug 46679] Delete and forward delete shouldn't start autocorrection panel timer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46679


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69099|review?                     |review-
               Flag|                            |




--- Comment #14 from mitz at webkit.org  2010-09-28 14:17:37 PST ---
(From update of attachment 69099)
View in context: https://bugs.webkit.org/attachment.cgi?id=69099&action=review

> WebCore/editing/TypingCommand.cpp:321
> +#if PLATFORM(MAC) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
>  void TypingCommand::typingAddedToOpenCommand(ETypingCommand commandTypeForAddedTyping)
> +#else
> +void TypingCommand::typingAddedToOpenCommand(ETypingCommand)
> +#endif

The complaint was about markMisspellingsAfterTyping() having an unused (in some configurations) parameter, not about this method, so I’m not sure why you’re changing this one. I think it will break all builds.

The way to fix the warning about markMisspellingsAfterTyping() is to add
UNUSED_PARAM(commandType)
for the configurations that don’t use commandType.

You’ll need to make sure that you’re including <wtf/UnusedParam.h>—but I think you have it by way of including Editor.h.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.