[Webkit-unassigned] [Bug 46493] [chromium] Add mipmap support for ImageLayerChromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46493


Vangelis Kokkevis <vangelis at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69041|review?                     |review-
               Flag|                            |




--- Comment #10 from Vangelis Kokkevis <vangelis at chromium.org>  2010-09-28 13:14:35 PST ---
(From update of attachment 69041)
View in context: https://bugs.webkit.org/attachment.cgi?id=69041&action=review

> WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:109
> +

can you use String::contains() here instead of converting to a char* ?

> WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:269
> +        GLC(context, context->texParameterf(GraphicsContext3D::TEXTURE_2D, GraphicsContext3D::TEXTURE_MIN_FILTER, 

The filter mode setting can move up to the part that allocates the texture (where you call context->texImage2D) so you don't execute it every time.  You also need to make sure that you reset the filter modes when the tests fail as the layer size can change.

Also, it should be calling texParameteri instead of texParameterf (I think we have the same problem elsewhere in the code)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.