[Webkit-unassigned] [Bug 11154] Soft hyphenation and the clipboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=11154


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69076|review?                     |review+
               Flag|                            |




--- Comment #11 from Darin Adler <darin at apple.com>  2010-09-28 11:49:53 PST ---
(From update of attachment 69076)
View in context: https://bugs.webkit.org/attachment.cgi?id=69076&action=review

Would be nice to add some test cases for things Alexey mentioned (double clicking to select a word, granularity functions) at some point.

> WebCore/ChangeLog:34
> +        (WebCore::foldQuoteMarkOrSoftHyphen): Renamed foldQuoteMark() to this and added folding of
> +        soft hpyhen to 0.

Tpyo.

> WebCore/editing/TextIterator.cpp:1549
> +        case softHyphen:
> +            return 0;

I think we might need a comment, not just change log, about why folding a soft hyphen to a U+0000 is helpful. It’s much more obvious why folding a quote mark to the ASCII equivalent is helpful, which is why that has no “why” comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.