[Webkit-unassigned] [Bug 46739] Vertical scroll bar on apple.com is too short with WebKit2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 28 11:26:33 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=46739
Darin Adler <darin at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #69074|review? |review-
Flag| |
--- Comment #3 from Darin Adler <darin at apple.com> 2010-09-28 11:26:33 PST ---
(From update of attachment 69074)
View in context: https://bugs.webkit.org/attachment.cgi?id=69074&action=review
review- because there is no reason to handle only the top two levels of FrameView.
> WebKit2/UIProcess/API/mac/WKView.mm:323
> + // Temporarily enable the resize indicator to make a the _ownsWindowGrowBox
> + // calculation work.
Comment should go on one line.
> WebKit2/WebProcess/WebPage/WebPage.cpp:578
> + const HashSet<RefPtr<Widget> >* viewChildren = view->children();
Why do we need to do this one level deep, and not multiple levels? Might be better to use the frame tree and walk all the frames, not just the top level subframes.
> WebKit2/WebProcess/WebPage/WebPage.cpp:583
> + static_cast<FrameView*>(widget)->invalidateScrollbars();
The “invalidate” terminology here seems unclear to me.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list