[Webkit-unassigned] [Bug 46291] Add AudioChannelMerger files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46291


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68415|review?                     |review-
               Flag|                            |




--- Comment #3 from Kenneth Russell <kbr at google.com>  2010-09-28 10:36:14 PST ---
(From update of attachment 68415)
View in context: https://bugs.webkit.org/attachment.cgi?id=68415&action=review

Looks good overall, but r- for similar issues as in AudioChannelSplitter.

> WebCore/webaudio/AudioChannelMerger.cpp:40
> +// This is considering that 5.1 (6 channels is the largest we'll ever deal with).

Same issue with comment as in AudioChannelSplitter.

> WebCore/webaudio/AudioChannelMerger.cpp:86
> +                outputChannelIndex++;

Use preincrement.

> WebCore/webaudio/AudioChannelMerger.cpp:98
> +void AudioChannelMerger::initialize()

Refactor these into AudioNode.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.