[Webkit-unassigned] [Bug 46732] New: Add a pre commit pass that checks for missing platform test expectations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46732

           Summary: Add a pre commit pass that checks for missing platform
                    test expectations
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: arv at chromium.org
                CC: eric at webkit.org, ossy at webkit.org


As a human I tend to forget things and that is why tools are good.

If I upload or land a patch that updates a test expectation it would be nice to have a script that checks if there is a platform specific expectation for the same test and then warns the user unless the patch also updates the platform specific tests.

After using webkit-patch upload (or land?) I would like to see something like this:

The following test(s) has platform specific expectations:

fast/dom/Window/window-properties.html:
    platform/gtk/fast/dom/Window/window-properties-expected.txt
    platform/qt/fast/dom/Window/window-properties-expected.txt
platform/qt/fast/dom/Window/window-property-descriptors.html
    platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt
    platform/qt/fast/dom/Window/window-property-descriptors-expected.txt

but this patch does not update these. Are you sure you want to continue? [Y/n]

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.