[Webkit-unassigned] [Bug 45443] [GTK] Support for viewport meta tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45443





--- Comment #10 from Joone Hur <joone at kldp.org>  2010-09-28 09:38:52 PST ---
> > WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:610
> > +    WebCore::FloatRect rect = core(webview)->chrome()->pageRect();
> 
> Remember that the device size has to be given as in portrait mode. or better said, device width = width in portrait, and device height = width in landscape (this is without any ui elements)

The device size can be set when a WebKitViewportConfig object is created through webkit_viewport_config_new, so the return value of pageRect() is not relevant to the device size.

According to the opera spec, "available-width is the width of the visual viewport (device-width - decorations) at scale factor 1.0"
I think that pageRect() can be used for getting the available-size. Of course, it can have the same value of the device width if there is no any border.

> > WebKit/gtk/webkit/webkitviewportconfig.cpp:40
> > +struct _WebKitViewportConfigPrivate {
> > +    gint width;
> > +    gint height;
> > +    gfloat targetDensityDPI;
> > +    gfloat initialScaleFactor;
> > +    gfloat minimumScaleFactor;
> > +    gfloat maximumScaleFactor;
> > +    gboolean isUserScalable;
> > +    gboolean isValid;
> > +    gint deviceDPI;
> > +    gint deviceWidth;
> > +    gint deviceHeight;
> > +    gint desktopWidth;
> > +};
> 
> You might want a way to extend this struct without causing ABI breakage

This is a private structure defined in cpp file , so applications cannot access this structure directly.

Thank you for the review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.