[Webkit-unassigned] [Bug 46710] [Chromium] Linking error due to wrong guard in WebIDBTransaction.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46710





--- Comment #8 from Jeremy Orlow <jorlow at chromium.org>  2010-09-28 08:24:08 PST ---
(In reply to comment #4)
> (In reply to comment #2)
> > (From update of attachment 69034 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=69034&action=review
> > 
> > r=me
> > 
> > > WebKit/chromium/public/WebIDBTransaction.h:65
> > > +        // FIXME: this is never called in the renderer. Find a cleaner solution.
> > 
> > Comments that apply to the whole function really seem like they should go right above the function not in them.  Is there other precedent for something like this?  If not, can you please stop doing this?
> > 
> 
> OK ok :)
> 
> > Also, try not to make the comments Chromium architecture specific.  Maybe just say that this is only meant to be called from within WebCore?
> 
> Erm, this bug has the [Chromium] label and the patch touches only a file in /WebKit/chromium so how can making a chromium-specific comment possibly be wrong?

WebKit code should not depend on Chromium code.  Even if this code is designed to be consumed by Chromium.

Plus Darin said so.  :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.