[Webkit-unassigned] [Bug 46710] [Chromium] Linking error due to wrong guard in WebIDBTransaction.h

Tue Sep 28 03:36:09 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=46710

Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69034|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #2 from Jeremy Orlow <jorlow at chromium.org>  2010-09-28 03:36:09 PST ---
(From update of attachment 69034)
View in context: https://bugs.webkit.org/attachment.cgi?id=69034&action=review

r=me

> WebKit/chromium/public/WebIDBTransaction.h:65
> +        // FIXME: this is never called in the renderer. Find a cleaner solution.

Comments that apply to the whole function really seem like they should go right above the function not in them.  Is there other precedent for something like this?  If not, can you please stop doing this?

Also, try not to make the comments Chromium architecture specific.  Maybe just say that this is only meant to be called from within WebCore?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.