[Webkit-unassigned] [Bug 46499] REGRESSION(63307): SVG elements fail to re-render

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46499





--- Comment #17 from Nikolas Zimmermann <zimmermann at kde.org>  2010-09-28 01:20:04 PST ---
(In reply to comment #16)
> Hi folks,
> 
> Naturally, I always prefer to ping a patch author before reverting if possible, but in this case it wasn't.  Given that the original patch was an incorrect perf optimization that caused a serious correctness regression reverting was an easy choice.

It was not incorrect. Your revert hides the fact, that we're not dealing display attribute changes correct for SVG renderers.

> As for the test the setTimeouts are less than ideal and you are welcome to improve the test.  It does test what it sets out to and I think fast/repaint is a fine place to put a repaint test.

I prefer to give that kind of feedback as review feedback, and you could improve your test, before landing.

To summarize: I don't like the attitude that's being shown here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.