[Webkit-unassigned] [Bug 46499] REGRESSION(63307): SVG elements fail to re-render

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46499





--- Comment #15 from Nikolas Zimmermann <zimmermann at kde.org>  2010-09-27 23:50:09 PST ---
(In reply to comment #13)
> In defense of James's actions (which I was not involved with): it's pretty standard policy to revert regressions.  It was unfortunate he hadn't updated the original bug, but it's also possible he was about to and I just beat him to it.
Sure, but when planning to revert a patch, the author should be given a chance to comment first.
It's not that we're releasing a new Safari/Chrome tomorrow, then it would have been fine IMHO.

> 
> I think it was pretty awesome that he landed a layout test at the same time to prevent any possible future regression.
The layout test is flawed. It's timing dependant: a test with two 50ms timeouts, always cries for a better solution. It's also in the wrong directory: svg/in-html would be the place to put new HTML5+SVG regression tests.

> You should feel free to roll back in your patch as soon as it doesn't regress.  Not repainting SVGs is a pretty major regression and I'm glad this was resolved promptly, rollout or otherwise.
It's only not repainting display changes, there's not a general repaint problem (of course, not repainting display changes is a pretty major bug).

> 
> Looking forward to seeing your original patch land again!

Definately.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.