[Webkit-unassigned] [Bug 29240] iframes keep getting scrollbars with scrolling="no"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29240





--- Comment #8 from MORITA Hajime <morrita at google.com>  2010-09-27 22:56:07 PST ---
(From update of attachment 68645)
View in context: https://bugs.webkit.org/attachment.cgi?id=68645&action=review

Hi, thank you for doing this!
Although i'm not a reviewer, I'd like to have a (shadow) review:

> LayoutTests/fast/frames/iframe-scrolling-attribute-overflowscroll.html:1
> +<style>

Could you do this in a dumpAsText()-based test, instead of relies on pixel test?
For example, how about to compare clientWidth of boxes with and without scrollbars?
dumpAstText()-based test is preferable because of its maintainability.

> WebCore/page/FrameView.cpp:721
> +

Could you make the computation of vMode and hMove more local?
If we can extract it into the function, it would be fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.