[Webkit-unassigned] [Bug 46531] Autocorrection panel is shown at incorrect location when WebView is scrolled.

Mon Sep 27 22:31:20 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=46531

mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68945|review?                     |review-
               Flag|                            |

--- Comment #2 from mitz at webkit.org  2010-09-27 22:31:20 PST ---
(From update of attachment 68945)
View in context: https://bugs.webkit.org/attachment.cgi?id=68945&action=review

> WebCore/editing/Editor.cpp:2719
> +                        RefPtr<ClientRect> clientRect = rangeToReplace->getBoundingClientRect();

I don’t think getBoundingClientRect() is appropriate here. It is high-level DOM API which calls updateLayoutIgnorePendingStylesheets() and creates a DOM object (ClientRect) which you don’t need for the client interface. I think you should call getBorderAndTextQuads() directly to get a vector of quads in view coordinates.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.