[Webkit-unassigned] [Bug 46299] Add HRTFPanner files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46299





--- Comment #7 from James Robinson <jamesr at chromium.org>  2010-09-27 17:57:58 PST ---
(From update of attachment 69002)
View in context: https://bugs.webkit.org/attachment.cgi?id=69002&action=review

> WebCore/platform/audio/HRTFPanner.cpp:47
> +const double HRTFPanner::MaxDelayTime = 0.012; // 12ms

why 12?

add the unit to the name - looks like it's seconds here so perhaps MaxDelayTimeSeconds

> WebCore/platform/audio/HRTFPanner.cpp:170
> +        // If we have a stereo input, implement a strange kind of panning with left source processed by left HRTF, and right source by right HRTF.

Should it be an error at a higher level to connect a stereo input to this sort of node?  That is an odd sounding pan.

> WebCore/platform/audio/HRTFPanner.h:43
> +    HRTFPanner(double sampleRate)

one-arg constructor needs to be explicit

could the constructor definition be moved to the .cpp? I'm a little concerned about inlining the c'tor for FFTConvolver and DelayDSPKernel without know how big they are

please declare a virtual d'tor and define it in the .cpp

> WebCore/platform/audio/HRTFPanner.h:71
> +    // For de-zippering
> +    bool m_isFirstRender;
> +    int m_azimuthIndex;

What's de-zippering?

Comments should be sentences

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.