[Webkit-unassigned] [Bug 46233] Add HRTFDatabase files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46233


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68959|review?                     |review+
               Flag|                            |




--- Comment #6 from James Robinson <jamesr at chromium.org>  2010-09-27 16:53:54 PST ---
(From update of attachment 68959)
View in context: https://bugs.webkit.org/attachment.cgi?id=68959&action=review

Looks good.  Two nits, feel free to fix while landing or upload a new patch.

> WebCore/platform/audio/HRTFDatabase.cpp:78
> +                double x = double(jj) / double(InterpolationFactor);

nit: static_cast<double>()

> WebCore/platform/audio/HRTFDatabase.h:62
> +    HRTFDatabase(double sampleRate);

nit: this needs explicit

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.