[Webkit-unassigned] [Bug 46453] [NRWT] Put the http and websocket tests to end of the test list

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 27 16:50:36 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=46453





--- Comment #11 from Dirk Pranke <dpranke at chromium.org>  2010-09-27 16:50:35 PST ---
Another couple of comments, after having thought about this for a while ... there are at least two alternatives to taking out a global lock here.

The first would be to change the layout test infrastructure and DRT and TestShell to use dynamically selected ports. The idea would be to have the start_http_server() code dynamically select a free port (or set of ports if we're using SSL) and then pass that port to DRT. Inside DRT we could add a method to layoutTestController() to get the port to use for the specific kind of test.

Another would be to reference count the web server instead of insisting on a global lock, since AFAIK all of the tests are stateless on the server-side, so there's not a real reason why two different NRWT runs couldn't point at the same web server. This might be a bit buggier and harder to clean up, but it would also be less prone to deadlocking.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list