[Webkit-unassigned] [Bug 46635] test-webkitpy should have logging configured differently

Mon Sep 27 16:11:02 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=46635

--- Comment #7 from Dirk Pranke <dpranke at chromium.org>  2010-09-27 16:11:02 PST ---
(In reply to comment #6)
> So when we move all logging to go through logging.py instead of deprecatedlogging.py, how will we capture the logging output on a per-test basis for testing?  Can tests install their own handlers?  Should tests be disabling some global handlers?  Should OutputCapture?

I'm not sure how to answer that question, since it depends on what you want to try and do. Tests can certainly install their own handlers (that's what printing.py is doing), so if you wanted to test specific output recorded through logging calls, that would be the way to go.

On the other hand, if you want to test what, if anything, is being printed to stdout/stderr, you need to do something like OutputCapture, or change the code to take streams as input parameters (like new-run-webkit-tests does).

There isn't a good way for one subsystem to alter another subsystems' logging configuration safely; that's what I spent a lot of time trying to do in the previously mentioned task.

I don't quite know what Chris's original intent in test-webkitpy was, although I think it was intended to suppress logging during the initial phase of setup and then go back to normal. One option would be for it to remove its logging handler in the last step before it actually tries to run the tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.