[Webkit-unassigned] [Bug 46634] webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console

Mon Sep 27 11:37:35 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=46634

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68935|review?                     |review+
               Flag|                            |

--- Comment #3 from Eric Seidel <eric at webkit.org>  2010-09-27 11:37:35 PST ---
(From update of attachment 68935)
Seems OK.  We could care about the output.  assert_outputs will return the value of the function it calls.  The comment should probably say "Other tests cover output, this test only checks parsing behavior" or similar.

I guess I should implement __enter__ and __exit__ for OutputCapture so we can use it with "with"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.