[Webkit-unassigned] [Bug 46624] Web Inspector: implement pausing on event listeners (back-end part)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46624


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68917|review?                     |review+
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2010-09-27 09:42:08 PST ---
(From update of attachment 68917)
View in context: https://bugs.webkit.org/attachment.cgi?id=68917&action=review

> WebCore/bindings/js/ScriptDebugServer.cpp:@
>  void ScriptDebugServer::pause()

Lets be verbose here and call it "setPauseOnNextStatement".

> WebCore/dom/Node.cpp:2619
> +    InspectorController::instrumentWillDispatchEvent(document(), *event);

Could you move timeline agent call below into instrumentWillDispatch?

> WebCore/dom/Node.cpp:2712
> +    InspectorController::instrumentDidDispatchEvent(document());

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.