[Webkit-unassigned] [Bug 46565] [GTK] Doesn't build with gtk+ 2.14

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46565


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68892|review?                     |review-
               Flag|                            |




--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2010-09-27 07:49:24 PST ---
(From update of attachment 68892)
View in context: https://bugs.webkit.org/attachment.cgi?id=68892&action=review

Looks good. I just have a few small issues.

> WebCore/ChangeLog:8
> +        Fixed the build for GTK+ 2.14.

Please expand this a bit. Say that you added some backward-compatible stuff to GtkVersioning.

> WebCore/platform/gtk/GtkVersioning.c:80
> +    GdkColor fg = { 0, 65535, 0, 0 }; /* Red. */
> +    GdkColor bg = { 0, 0, 0, 65535 }; /* Blue. */

Please don't use abbreviations.

> WebCore/platform/gtk/GtkVersioning.c:82
> +        0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0};

This can be one line if it's less than 120 characters.

> WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp:181
> +    gdk_window_set_cursor(window, NULL);

This should be a 0 instead of NULL.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.