[Webkit-unassigned] [Bug 46614] New: Web Inspector: extract Inspector Instrumentation API as a class.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46614

           Summary: Web Inspector: extract Inspector Instrumentation API
                    as a class.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: loislo at chromium.org
                CC: timothy at apple.com, rik at webkit.org, keishi at webkit.org,
                    pmuellr at yahoo.com, joepeck at webkit.org,
                    pfeldman at chromium.org, yurys at chromium.org,
                    bweinstein at apple.com, loislo at chromium.org
        Depends on: 46611


There is a lot of places where we push information from WebCore to Inspector.
When we doing that we use Timeline agent, Debugger agent, InspectorController etc.
In some cases we need to have an instrumentation for Debugger agent and Timeline agent in the same place.
As example for XHR breakpoints.

I'd be great to extract an Inspector Instrumentation API which hide internal Inspector things from the rest of WebCore code. 

In this case we will have:
1) InspectorInstrumentation class as an API for WebCore;
2) inspector agents with business logic for different inspector's activities;
3) InspectorBackendDispatcher class as the api for front-end;
4) InspectorController as the controller for all Inspector stuff.

We already have last three things and want to have the first one.

I've plan to make next patches:
1) split Timeline Agent implementation. The first part will be used as a base for InspectorInstrumentation class in the following patches, the second is InspectorTimeline agent itself.
2) extract API part of InspectorTimeline agent into separate file and rename it to InspectorInstrumentation. A lot of places in WebCore will be fixed too.
3) move current implementation of DOM breakpoints in WebCore under control of InspectorInstrumentation.
4) move other things under control of InspectorInstrumentation too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.