[Webkit-unassigned] [Bug 46565] [GTK] Doesn't build with gtk+ 2.14

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46565


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #5 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-09-27 02:29:11 PST ---
Attachment 68889 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp:181:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/gtk/GtkVersioning.c:63:  gdk_window_get_root_coords is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/GtkVersioning.c:71:  Declaration has space between * and variable name in GdkCursor* blankCursor  [whitespace/declaration] [3]
WebCore/platform/gtk/GtkVersioning.c:76:  Declaration has space between * and variable name in GdkCursor* cursor  [whitespace/declaration] [3]
WebCore/platform/gtk/GtkVersioning.c:77:  Declaration has space between * and variable name in GdkPixmap* source  [whitespace/declaration] [3]
WebCore/platform/gtk/GtkVersioning.c:78:  Declaration has space between * and variable name in GdkPixmap* mask  [whitespace/declaration] [3]
WebCore/platform/gtk/GtkVersioning.c:81:  cursor_bits is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/GtkVersioning.c:94:  gtk_menu_item_get_label is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/GtkVersioning.c:94:  menu_item is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/GtkVersioning.c:96:  Declaration has space between * and variable name in GtkWidget* label  [whitespace/declaration] [3]
WebCore/platform/gtk/GtkVersioning.c:101:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/gtk/GtkVersioning.h:60:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/platform/gtk/GtkVersioning.h:69:  gdk_window_get_root_coords is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/GtkVersioning.h:73:  gtk_menu_item_get_label is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/GtkVersioning.h:73:  menu_item is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/gtk/GtkVersioning.h:74:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 16 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.