[Webkit-unassigned] [Bug 46405] Add idl and mock classes for FileSystemSync for FileSystem API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46405





--- Comment #2 from Adam Barth <abarth at webkit.org>  2010-09-26 22:13:28 PST ---
(From update of attachment 68597)
View in context: https://bugs.webkit.org/attachment.cgi?id=68597&action=review

> WebCore/bindings/js/JSDirectoryEntrySyncCustom.cpp:59
> +        JSValue jsCreate = object->get(exec, Identifier(exec, "create"));

This call re-enters JavaScript and can do arbitrary things.  How do we know that |object| hasn't been deallocated?  What about |imp|?

> WebCore/bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:75
> +    } else {
> +       EXCEPTION_BLOCK(Flags*, tmp_flags, V8Flags::HasInstance(args[1]) ? V8Flags::toNative(v8::Handle<v8::Object>::Cast(args[1])) : 0);
> +       flags = tmp_flags;
> +    }

Bad indent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.