[Webkit-unassigned] [Bug 46524] Bridge all FileSystem operations on Workers to the MainThread

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46524





--- Comment #2 from Dumitru Daniliuc <dumi at chromium.org>  2010-09-24 16:21:36 PST ---
(From update of attachment 68771)
View in context: https://bugs.webkit.org/attachment.cgi?id=68771&action=review

a couple of nits.

> WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp:48
>  WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl(PassOwnPtr<AsyncFileSystemCallbacks> callbacks)

no need for this constructor. webkit allows default parameters.

> WebKit/chromium/src/WebFileSystemCallbacksImpl.h:55
> +    WebFileSystemCallbacksImpl(PassOwnPtr<WebCore::AsyncFileSystemCallbacks>, WebCore::ScriptExecutionContext*);

WebCore::ScriptExecutionContext* = 0, and remove the other constructor.

> WebKit/chromium/src/WorkerAsyncFileSystemChromium.cpp:63
> +    ASSERT(m_scriptExecutionContext && m_scriptExecutionContext->isWorkerContext());

you can just do ASSERT(m_scriptExecutionContext->isWorkerContext()).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.