[Webkit-unassigned] [Bug 46529] Output X-Purpose header for prefetch requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46529





--- Comment #4 from Gavin Peters <gavinp at chromium.org>  2010-09-24 15:54:38 PST ---
(In reply to comment #3)
> (From update of attachment 68773 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68773&action=review
> 
> > LayoutTests/http/tests/misc/prefetch-purpose.html:11
> > +    setTimeout("finishUp()",50);
> 
> This is racy, no?
> 

Yes, but there's no good way around this.  The finishUp() call must occur after prefetches have loaded, and there's no programmatic way to know about this.  I think this came up before when we tested prefetching, and I used the same timeout here: http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/HTMLLinkElement/prefetch.html


> Also, we should do this unconditionally in the load event handler.
> 
> > LayoutTests/http/tests/misc/resources/prefetch-purpose.php:6
> > +    echo $_COOKIE['X-Purpose'];
> 
> Do we need to clear the cookie in this response?  Otherwise, this state will leak into other tests.

Yes.  Fixed, new upload coming.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.