[Webkit-unassigned] [Bug 46234] Add HRTFDatabaseLoader files

Fri Sep 24 15:34:11 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=46234

James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68315|review?                     |review-
               Flag|                            |

--- Comment #2 from James Robinson <jamesr at chromium.org>  2010-09-24 15:34:11 PST ---
(From update of attachment 68315)
View in context: https://bugs.webkit.org/attachment.cgi?id=68315&action=review

How is this class supposed to be used?  It seems that a user would first call loadAsynchronously(), but then have nothing better to do but poll isLoaded() until it returns true, which doesn't seem very useful.  Should this expose a callback for users?

r- for the unsafe use of RefPtr across threads.

> WebCore/platform/audio/HRTFDatabaseLoader.cpp:76
> +        m_hrtfDatabase = HRTFDatabase::createForSubject("Composite", m_databaseSampleRate);

It is not safe to increment a reference on a RefCounted object from one thread and then increment/decrement references from another thread.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.