[Webkit-unassigned] [Bug 45812] Filter builder should be able to follow the filter object dependencies

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45812


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68673|review?                     |review-
               Flag|                            |




--- Comment #12 from Dirk Schulze <krit at webkit.org>  2010-09-24 08:37:09 PST ---
(From update of attachment 68673)
View in context: https://bugs.webkit.org/attachment.cgi?id=68673&action=review

Otherwise looks great!

> WebCore/svg/graphics/filters/SVGFilterBuilder.cpp:82
> +    m_effectReferences.add(effect, FilterEffectSet());
> +
> +    FilterEffectVector& inputEffects = effect->inputEffects();
> +    int size = inputEffects.size();
> +
> +    // It is not possible to add the same value to a set twice.
> +    for (int i = 0; i < size; ++i)
> +        getEffectReferences(effect.get()).add(inputEffects[i].get());

Please use numberOfInputEffects and inputEffect(unsigned) instead of the EffectVector. Store the pointer effect.get() in a own variable.

> WebCore/svg/graphics/filters/SVGFilterBuilder.cpp:90
> +    addBuiltinEffects();

Please remove this from clearEffects().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.