[Webkit-unassigned] [Bug 45381] [Gtk] Adjust atk_text_get_text_at_offset to account for bullets/numbers in list items

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45381


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68509|0                           |1
        is obsolete|                            |
  Attachment #68509|review?                     |
               Flag|                            |
  Attachment #68677|                            |review?
               Flag|                            |




--- Comment #12 from Mario Sanchez Prada <msanchez at igalia.com>  2010-09-24 07:39:13 PST ---
Created an attachment (id=68677)
 --> (https://bugs.webkit.org/attachment.cgi?id=68677)
Patch proposal + unit test updated

(In reply to comment #11)
> (In reply to comment #10)
> > [...]
> > Well, the goal is (of course) to present to the user what's on the screen. And what's visually
> > on the screen looks like "1. item content here". The fact that this appearance was achieved 
> > by rendering magic other than the addition of an actual space character is, as far as the end 
> > user is concerned, irrelevant. Thus I'm afraid we do need the space added.
> 
> Ok. Then I'll try to come up with a patch dealing with that extra space. I've just checked what firefox does in thit case and it seems they also add that extra space, so let's follow the ff lead.
> 
> Thanks for the feedback.

Attaching a new patch that also returns the extra space, when needed, along with the marker's suffix, so calling to RenderListMarker::suffix() returns the same string that is going to be rendered when painting between the list item and the item's content.

Hence, asking for review over this new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.