[Webkit-unassigned] [Bug 46408] Add C API to WebKit2 for changing the font families

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 24 07:01:07 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=46408





--- Comment #3 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-09-24 07:01:06 PST ---
(In reply to comment #2)
> > > +WKStringRef WKPreferencesGetFantasyFontFamily(WKPreferencesRef preferencesRef)
> > > +{
> > > +    return toCopiedRef(toWK(preferencesRef)->fantasyFontFamily());
> > > +}
> > 
> > Since all the getters here return copied strings, these need to have the word copy in them instead of get.
> 
> Should they be called Copy instead of Get? I see that elsewhere in WebKit2.
> 
> Like: WKPreferencesCopyFantasyFontFamily ?

I should have read your comment better :-) still waking up.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list