[Webkit-unassigned] [Bug 46262] [Qt] [WebKit2] Workarounds for the flash plugin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46262





--- Comment #6 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-09-24 06:09:25 PST ---
(From update of attachment 68510)
View in context: https://bugs.webkit.org/attachment.cgi?id=68510&action=review

> WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:447
> +#elif PLATFORM(QT)

Won't this be the same for GTK+ etc? Would it break anything having this enabled for all ports?

> WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:66
> +#if PLATFORM(QT)
> +    WebCore::PluginQuirkSet quirks() const { return m_quirks; }
> +#endif

Shouldn't all platforms support plugin quirks?

> WebKit2/WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:52
> +    } else if (FlashPluginWorkarounds::isFlashPlugin(pluginPath)) {
> +        // We have already loaded the plugin but initializeGTK
> +        // needs a QLibrary for resolving gtk_init.
> +        QLibrary flashPlugin(pluginPath);
> +        ASSERT(flashPlugin.load());
> +        FlashPluginWorkarounds::initializeGTK(&flashPlugin);

So are we loading it twice?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.