[Webkit-unassigned] [Bug 46408] Add C API to WebKit2 for changing the font families

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46408


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68595|review?                     |review-
               Flag|                            |




--- Comment #1 from Sam Weinig <sam at webkit.org>  2010-09-23 23:52:39 PST ---
(From update of attachment 68595)
View in context: https://bugs.webkit.org/attachment.cgi?id=68595&action=review

> WebKit2/UIProcess/API/C/WKPreferences.cpp:160
> +void WKPreferencesSetStandardFontFamily(WKPreferencesRef preferencesRef, WKStringRef family)
> +{
> +    toWK(preferencesRef)->setStandardFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WebPreferencesGetStandardFontFamily(WKPreferencesRef preferencesRef)
> +{
> +    return toCopiedRef(toWK(preferencesRef)->standardFontFamily());
> +}
> +
> +void WKPreferencesSetFixedFontFamily(WKPreferencesRef preferencesRef, WKStringRef family)
> +{
> +    toWK(preferencesRef)->setFixedFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WKPreferencesGetFixedFontFamily(WKPreferencesRef preferencesRef)
> +{
> +    return toCopiedRef(toWK(preferencesRef)->fixedFontFamily());
> +}
> +
> +void WKPreferencesSetSerifFontFamily(WKPreferencesRef preferencesRef, WKStringRef family)
> +{
> +    toWK(preferencesRef)->setSerifFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WKPreferencesGetSerifFontFamily(WKPreferencesRef preferencesRef)
> +{
> +    return toCopiedRef(toWK(preferencesRef)->serifFontFamily());
> +}
> +
> +void WKPreferencesSetSansSerifFontFamily(WKPreferencesRef preferencesRef, WKStringRef family)
> +{
> +    toWK(preferencesRef)->setSansSerifFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WKPreferencesGetSansSerifFontFamily(WKPreferencesRef preferencesRef)
> +{
> +    return toCopiedRef(toWK(preferencesRef)->sansSerifFontFamily());
> +}
> +
> +void WKPreferencesSetCursiveFontFamily(WKPreferencesRef preferencesRef, WKStringRef family)
> +{
> +    toWK(preferencesRef)->setCursiveFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WKPreferencesGetCursiveFontFamily(WKPreferencesRef preferencesRef)
> +{
> +    return toCopiedRef(toWK(preferencesRef)->cursiveFontFamily());
> +}
> +
> +void WKPreferencesSetFantasyFontFamily(WKPreferencesRef preferencesRef, WKStringRef family)
> +{
> +    toWK(preferencesRef)->setFantasyFontFamily(toWTFString(family));
> +}
> +
> +WKStringRef WKPreferencesGetFantasyFontFamily(WKPreferencesRef preferencesRef)
> +{
> +    return toCopiedRef(toWK(preferencesRef)->fantasyFontFamily());
> +}

Since all the getters here return copied strings, these need to have the word copy in them instead of get.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.