[Webkit-unassigned] [Bug 45416] Allow Chromium port to link with system-provided SQLite

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45416


Dumitru Daniliuc <dumi at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68364|review?                     |review+
               Flag|                            |




--- Comment #12 from Dumitru Daniliuc <dumi at chromium.org>  2010-09-23 18:04:33 PST ---
(From update of attachment 68364)
View in context: https://bugs.webkit.org/attachment.cgi?id=68364&action=review

r=me, but please patch this change into chromium __on linux and mac__, and make sure all LayoutTests/storage tests pass before you submit it. if you're not a webkit committer, please address my comment and upload a new patch, and i'll r+/cq+ it.

> WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:756
> +    bool success = false;
> +    if (fullSync)
> +        success = !fcntl(fd, F_FULLSYNC, 0);
> +    if (!success)
> +        success = !fsync(fd);

missing return statement for PLATFORM(MAC). please test the patch on both linux and mac.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.